This bugzilla service is closed. All entries have been migrated to https://gitlab.com/libeigen/eigen
Bug 604 - [feature request] triangularView < Eigen::Diagonal > ()
Summary: [feature request] triangularView < Eigen::Diagonal > ()
Status: CONFIRMED
Alias: None
Product: Eigen
Classification: Unclassified
Component: General (show other bugs)
Version: 3.3 (current stable)
Hardware: All All
: Normal Feature Request
Assignee: Nobody
URL:
Whiteboard:
Keywords: JuniorJob
Depends on: ExprEval
Blocks: 3.x
  Show dependency tree / graph
 
Reported: 2013-05-22 11:13 UTC by Kolja Brix
Modified: 2019-12-04 12:20 UTC (History)
3 users (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kolja Brix 2013-05-22 11:13:44 UTC 
Dear Eigen developers,

to have a consistent API, wouldn't it be a good idea to provide

mat.triangularView < Eigen::Diagonal > ()

or 

mat.diagonalView()

to access the diagonal of a dense/sparse matrix?
Comment 1 Gael Guennebaud 2013-05-22 11:41:13 UTC 
Clearly not trough triangularView, but  mat.diagonalView()  could be a shortcut for:

mat.diagonal().asDiagonal()
Comment 2 Kolja Brix 2013-05-22 11:49:40 UTC 
Ok, the shortcut would be great.

What about adding a solve() and solveInPlace() functionality?
Comment 3 Gael Guennebaud 2013-05-22 11:52:16 UTC 
I would rather add the "inverse() *" and "* inverse()" feature to all other solvers, but that requires bug 99 first. Adding solve() is more straightforward for now.
Comment 4 Christoph Hertzberg 2014-11-02 18:54:24 UTC 
I guess that's easy enough to be included to 3.3
Comment 5 Gael Guennebaud 2016-01-29 11:49:22 UTC 
I'm leaving it for newcomers, this is an excellent junior-job to learn how to add a method with proper documentation, example, and unit-test.
Comment 6 Nobody 2019-12-04 12:20:17 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/604.
Note You need to log in before you can comment on or make changes to this bug.