This bugzilla service is closed. All entries have been migrated to https://gitlab.com/libeigen/eigen
Bug 483 - Optimize outer products for non rank-1 update operation
Summary: Optimize outer products for non rank-1 update operation
Status: RESOLVED FIXED
Alias: None
Product: Eigen
Classification: Unclassified
Component: Core - matrix products (show other bugs)
Version: unspecified
Hardware: All All
: Normal Unknown
Assignee: Nobody
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 3.2
  Show dependency tree / graph
 
Reported: 2012-06-28 18:50 UTC by Gael Guennebaud
Modified: 2019-12-04 11:45 UTC (History)
0 users


Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gael Guennebaud 2012-06-28 18:50:32 UTC 
Currently the outer product impl. is optimized for:

 A += v1 * v2.transpose();

making a simple:

A = v1 * v2.transpose();

significantly slower than what it could be because of the additional A.setZero() and additional adds.
Comment 1 Gael Guennebaud 2013-02-25 13:32:49 UTC 
Not very elegant, but it works:

https://bitbucket.org/eigen/eigen/commits/086be9eedd4b/
changeset:   086be9eedd4b
user:        ggael
date:        2013-02-25 13:31:42
summary:     Fix bug 483: optimize outer-products to skip setZero and a scalar multiple when not needed.
Comment 2 Nobody 2019-12-04 11:45:28 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/483.
Note You need to log in before you can comment on or make changes to this bug.