This bugzilla service is closed. All entries have been migrated to https://gitlab.com/libeigen/eigen
Bug 454 - [patch] to allow Map classes to act as 'x' or 'b' in SuperLU solve
Summary: [patch] to allow Map classes to act as 'x' or 'b' in SuperLU solve
Status: RESOLVED FIXED
Alias: None
Product: Eigen
Classification: Unclassified
Component: Unsupported modules (show other bugs)
Version: 3.0
Hardware: All All
: Normal enhancement
Assignee: Nobody
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 3.1
  Show dependency treegraph
 
Reported: 2012-04-26 20:10 UTC by adam.p.harrison
Modified: 2019-12-04 11:37 UTC (History)
1 user (show)



Attachments
Patch for the solution I came up with (975 bytes, patch)
2012-04-26 20:10 UTC, adam.p.harrison
adam.p.harrison: review?
Details | Diff

Description adam.p.harrison 2012-04-26 20:10:53 UTC
Created attachment 265 [details]
Patch for the solution I came up with

SuperLUSupport.h does not allow a Eigen::Map class to act as 'x' or 'b' in the solve routine. I had a need to use already allocated data to act as 'x', so I simply added an additional Map structure (note the duplication of names here, I am referring to what was called MaptoSLU in 3.0.4) that can accept an Eigen::Map and convert it to the SLuMatrix datatype. 

My solution has a lot of duplication with the Matrix conversion to SLuMatrix code, so there's probably a better way to do this, but as I am not versed in the Eigen source code I didn't want to mess about with pre-existing structures.
Comment 1 Gael Guennebaud 2012-05-01 21:41:12 UTC
Indeed there exist a cleaner and more general solution. We should support any dense expressions and check the other solver for the same shortcoming.
Comment 2 Gael Guennebaud 2012-06-06 09:49:30 UTC
https://bitbucket.org/eigen/eigen/changeset/6fb8277e9ad6/
changeset:   6fb8277e9ad6
user:        ggael
date:        2012-06-06 09:37:59
summary:     Fix bug 454: allow Block/Map objects for solving with SuperLU
Comment 3 Nobody 2019-12-04 11:37:34 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/454.

Note You need to log in before you can comment on or make changes to this bug.