This bugzilla service is closed. All entries have been migrated to
Bug 415 - Return value of Rotation2D::operator*= is invalid.
Summary: Return value of Rotation2D::operator*= is invalid.
Alias: None
Product: Eigen
Classification: Unclassified
Component: Geometry (show other bugs)
Version: 3.0
Hardware: All All
: Normal Unknown
Assignee: Nobody
Depends on:
Reported: 2012-02-06 16:50 UTC by Erik.Einhorn
Modified: 2019-12-04 11:26 UTC (History)
3 users (show)


Description Erik.Einhorn 2012-02-06 16:50:38 UTC
Geometry/Rotation2D.h(92) contains the following code:

  inline Rotation2D& operator*=(const Rotation2D& other)
  { return m_angle += other.m_angle; return *this; }

There are two returns in this method. Probably the first one came by copy&pasting it from the operator*(). The code should be modified to:

  inline Rotation2D& operator*=(const Rotation2D& other)
  { m_angle += other.m_angle; return *this; }
Comment 1 Gael Guennebaud 2012-02-08 21:53:14 UTC
you're perfectly right, thanks for the report, just in time for 3.0.5....
changeset:   da01029bc8eb
date:        2012-02-08 21:50:51
summary:     fix bug 415: wrong return in Rotation2D::operator*=
changeset:   f9e92ba25ad6
branch:      3.0
Comment 2 Nobody 2019-12-04 11:26:43 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance:

Note You need to log in before you can comment on or make changes to this bug.