This bugzilla service is closed. All entries have been migrated to https://gitlab.com/libeigen/eigen
Bug 281 - replace macros by inline functions
Summary: replace macros by inline functions
Status: RESOLVED FIXED
Alias: None
Product: Eigen
Classification: Unclassified
Component: Sparse (show other bugs)
Version: 3.0
Hardware: All All
: --- minor
Assignee: Nobody
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 3.1
  Show dependency tree / graph
 
Reported: 2011-05-30 17:24 UTC by Christoph Hertzberg
Modified: 2019-12-04 10:48 UTC (History)
1 user (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Christoph Hertzberg 2011-05-30 17:24:58 UTC 
SparseExtra/Amd.h defines the following macros which could easily be replaced by inline functions (thus avoiding warnings when also including CSparse headers)

#define CS_FLIP(i) (-(i)-2)
#define CS_UNFLIP(i) (((i) < 0) ? CS_FLIP(i) : (i))
#define CS_MARKED(w,j) (w[j] < 0)
#define CS_MARK(w,j) { w[j] = CS_FLIP (w[j]); }
Comment 1 Gael Guennebaud 2011-05-30 20:15:15 UTC 
totally agree!
Comment 2 Gael Guennebaud 2011-12-04 19:16:06 UTC 
https://bitbucket.org/eigen/eigen/changeset/03e8ba5bde7b/
changeset:   03e8ba5bde7b
date:        2011-12-04 19:15:23
summary:     fix bug 281: replace csparse macros by template functions
Comment 3 Nobody 2019-12-04 10:48:59 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/281.
Note You need to log in before you can comment on or make changes to this bug.