Some resize functionality is currently located in PlainObjectBase. We should move that to DenseBase.
The idea is to be able to write generic code and allow resizing on expressions. This would be a NOP in cases where the expressions already have the requested size.
We might want to discuss at some point whether it is the right approach to template over DenseBase<Derived> when an algorithm requires resizing.
Maybe I'm missing something, but DenseBase seems to have had resize functionality since its creation:
Ok, sorry for the hasty closing. I guess you intended to actually call
derived()->resize(...) from DenseBase::resize(...)?
I'm not entirely against that, but we need to carefully avoid recursion where if Derived does not implement resize.
I guess that the idea is rather to move the other variants of resize, i.e., the ones taking NoChange, conservativeResize, etc.
-- GitLab Migration Automatic Message --
This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity.
You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/196.