This bugzilla service is closed. All entries have been migrated to https://gitlab.com/libeigen/eigen
Bug 1477 - llt_rank_update_lower uses dynamic matrix type where it is not always needed.
Summary: llt_rank_update_lower uses dynamic matrix type where it is not always needed.
Status: NEW
Alias: None
Product: Eigen
Classification: Unclassified
Component: Cholesky (show other bugs)
Version: unspecified
Hardware: All All
: Normal Optimization
Assignee: Nobody
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-10-19 13:57 UTC by Christopher Wecht
Modified: 2019-12-04 17:14 UTC (History)
2 users (show)



Attachments
Patch which fixes the problem. (943 bytes, patch)
2017-10-19 13:57 UTC, Christopher Wecht
no flags Details | Diff
Cholesky test is now checking, if dynamic allocation is used on non-dynamic matrices (2.83 KB, patch)
2017-11-22 10:02 UTC, Christopher Wecht
no flags Details | Diff

Description Christopher Wecht 2017-10-19 13:57:35 UTC
Created attachment 797 [details]
Patch which fixes the problem.

In llt_rank_update_lower TempVectorType is dynamic. This might cause problems if one wants to use this function (directly or indirectly) in a situation where dynamic allocations are prohibited like embedded devices or in real-time-context.

The patch I've attached sovles the problem; the patch it self is basically taken from here: https://github.com/sfwa/ukf. This project is also a really good use-case.
Comment 1 Christopher Wecht 2017-11-22 10:02:27 UTC
Created attachment 807 [details]
Cholesky test is now checking, if dynamic allocation is used on non-dynamic matrices
Comment 2 Nobody 2019-12-04 17:14:26 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/1477.

Note You need to log in before you can comment on or make changes to this bug.