This bugzilla service is closed. All entries have been migrated to https://gitlab.com/libeigen/eigen
Bug 1335 - Catalogue should tell FullPivHouseholderQR gives least squares solutions to overdetermined systems
Summary: Catalogue should tell FullPivHouseholderQR gives least squares solutions to o...
Status: CONFIRMED
Alias: None
Product: Eigen
Classification: Unclassified
Component: Documentation (show other bugs)
Version: 3.3 (current stable)
Hardware: All All
: Normal Unknown
Assignee: Nobody
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-28 10:08 UTC by Zsbán Ambrus
Modified: 2019-12-04 16:28 UTC (History)
4 users (show)



Attachments

Description Zsbán Ambrus 2016-10-28 10:08:24 UTC
The documentation page "Catalogue of dense decompositions" ("http://eigen.tuxfamily.org/dox-devel/group__TopicLinearAlgebraDecompositions.html
") tells that the JacobiSVD decomposition can give you least squares solutions to overdetermined linear systems.  However, that table doesn't tell you that the FullPivHouseholderQR decomposition can also do that.  The documentation for the FullPivHouseholderQR::solve function ("http://eigen.tuxfamily.org/dox-devel/classEigen_1_1FullPivHouseholderQR.html#a18fa0031972cf8575deff77d65f75453") claims that it can do that. 

Make sure that the FullPivHouseholderQR::solve function indeed gives linear least squares solutions.  If so, then please do the following changes to the documentation.  Firstly, in the Catalogue page, in row FullPivHouseholderQR, change the "Allows to compute" column value to "Orthogonalization, least squares for overdetermined systems", and change the "Linear solver provided by Eigen" column value to "Yes (and does least squares)".  Note that the "overdetermined systems" part is important, because sometimes people talk about least squares solutions for systems with more variables than equations, in which case the least squares solution means one where the solution has the least 2-norm.  Then, in the documentation for FullPivHouseholderQR::solve, explain that the least squares solution means a solution where the 2-norm of (Ax-b) is minimal.  This is already explained for JacobiSVD in the docs for JacobiSVD::solve ("http://eigen.tuxfamily.org/dox-devel/classEigen_1_1SVDBase.html#a34c762f9b7eeb5ffc593ac20a5efe4a4").
Comment 1 Gael Guennebaud 2016-11-03 10:15:22 UTC
Yes, all QR decompositions compute the least square solution for overdetermined system. Feel free to submit a patch.
Comment 2 Nobody 2019-12-04 16:28:16 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/1335.

Note You need to log in before you can comment on or make changes to this bug.