This bugzilla service is closed. All entries have been migrated to https://gitlab.com/libeigen/eigen
Bug 1217 - Add -Wconversion flag to our test-suite
Summary: Add -Wconversion flag to our test-suite
Status: CONFIRMED
Alias: None
Product: Eigen
Classification: Unclassified
Component: Tests (show other bugs)
Version: 3.4 (development)
Hardware: All All
: Lowest Internal Design
Assignee: Nobody
URL:
Whiteboard:
Keywords: JuniorJob
Depends on:
Blocks: 3.x
  Show dependency tree / graph
 
Reported: 2016-05-05 11:53 UTC by Christoph Hertzberg
Modified: 2019-12-04 15:46 UTC (History)
3 users (show)


Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Christoph Hertzberg 2016-05-05 11:53:27 UTC 
This could help identifying some unwanted implicit conversions. But currently, it would generate more noise than it would help.
Comment 1 Christoph Hertzberg 2016-05-05 11:56:25 UTC 
Low priority & Volunteer job
If someone wants to do this: Just start by enabling the flag
  ei_add_cxx_compiler_flag("-Wconversion")
inside the root CMakeLists.txt, compile the test-suite and fix the warnings.
Comment 2 Christoph Hertzberg 2018-11-20 15:26:45 UTC 
In some cases the most #pragma-tic solution might be to disable conversion warnings locally, similar to this SO-answer:
https://stackoverflow.com/a/36175016
Comment 3 Nobody 2019-12-04 15:46:35 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/1217.
Note You need to log in before you can comment on or make changes to this bug.