Summary: | Differentiate the two usage of Index types | ||
---|---|---|---|
Product: | Eigen | Reporter: | Gael Guennebaud <gael.guennebaud> |
Component: | General | Assignee: | Nobody <eigen.nobody> |
Status: | RESOLVED FIXED | ||
Severity: | API Change | CC: | chtz, gael.guennebaud, jacob.benoit.1 |
Priority: | Normal | ||
Version: | 3.3 (current stable) | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: | |||
Bug Depends on: | |||
Bug Blocks: | 331, 877 |
Description
Gael Guennebaud
2013-03-21 15:46:58 UTC
This does not strictly block bug 877, but removing typedef Index from all classes would partially simplify resolving that. Agreement for bug 877 was to add a global Index typedef, and explicitly use that in the interface (where it makes a difference). For now, I would suggest to still return the actually used Index type for methods like rows(), cols() in order to avoid conversion warnings if users store their result as int (for SparseMatrix<..., int>). See bug 877 comment 20 for an update on this. Fixed through this merge: https://bitbucket.org/eigen/eigen/commits/b5be5e10eb7f/ -- GitLab Migration Automatic Message -- This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/572. |