|Summary:||name of constant|
|Product:||Eigen||Reporter:||Benito van der Zander <benito>|
|Component:||Core - general||Assignee:||Nobody <eigen.nobody>|
|Severity:||API Change||CC:||chtz, gael.guennebaud, jacob.benoit.1|
|Bug Depends on:|
Description Benito van der Zander 2011-08-07 23:05:11 UTC
In Constants.h there is a definition "const int Infinity = -1;" This is a very bad name, because it is easily confused with an constant for an actual infinity (i.e. INFINITY); and doesn't reflect the fact that it means the infinity norm. You should use something like InfinityNorm. (This becomes especially annoying if you use Qt Creator which autocompletes "INF" to "Infinity")
Comment 1 Gael Guennebaud 2011-08-23 09:22:50 UTC
We cannot change that name since that would break the API. Perhaps this could be considered for Eigen 4 in a very far future...
Comment 2 Benoit Jacob 2011-08-23 23:44:06 UTC
We can however introduce a new constant with the same value; and possibly mark the existing one as deprecated.
Comment 3 Nobody 2019-12-04 11:00:49 UTC
-- GitLab Migration Automatic Message -- This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/323.