This bugzilla service is closed. All entries have been migrated to

Bug 281

Summary: replace macros by inline functions
Product: Eigen Reporter: Christoph Hertzberg <chtz>
Component: SparseAssignee: Nobody <eigen.nobody>
Severity: minor CC: gael.guennebaud
Priority: ---    
Version: 3.0   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 55    

Description Christoph Hertzberg 2011-05-30 17:24:58 UTC
SparseExtra/Amd.h defines the following macros which could easily be replaced by inline functions (thus avoiding warnings when also including CSparse headers)

#define CS_FLIP(i) (-(i)-2)
#define CS_UNFLIP(i) (((i) < 0) ? CS_FLIP(i) : (i))
#define CS_MARKED(w,j) (w[j] < 0)
#define CS_MARK(w,j) { w[j] = CS_FLIP (w[j]); }
Comment 1 Gael Guennebaud 2011-05-30 20:15:15 UTC
totally agree!
Comment 2 Gael Guennebaud 2011-12-04 19:16:06 UTC
changeset:   03e8ba5bde7b
date:        2011-12-04 19:15:23
summary:     fix bug 281: replace csparse macros by template functions
Comment 3 Nobody 2019-12-04 10:48:59 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: