This bugzilla service is closed. All entries have been migrated to https://gitlab.com/libeigen/eigen

Bug 196

Summary: Move all resize functionality to DenseBase
Product: Eigen Reporter: Hauke Heibel <hauke.heibel>
Component: Core - generalAssignee: Nobody <eigen.nobody>
Status: DECISIONNEEDED ---    
Severity: API Change CC: chtz, gael.guennebaud, jacob.benoit.1
Priority: Normal    
Version: unspecified   
Hardware: All   
OS: All   
Whiteboard:

Description Hauke Heibel 2011-02-24 15:34:46 UTC
Some resize functionality is currently located in PlainObjectBase. We should move that to DenseBase. 

The idea is to be able to write generic code and allow resizing on expressions. This would be a NOP in cases where the expressions already have the requested size.

We might want to discuss at some point whether it is the right approach to template over DenseBase<Derived> when an algorithm requires resizing.
Comment 1 Christoph Hertzberg 2014-11-03 15:46:13 UTC
Maybe I'm missing something, but DenseBase seems to have had resize functionality since its creation:
https://bitbucket.org/eigen/eigen/src/f6ccbdd635c0/Eigen/src/Core/DenseBase.h#cl-168
Comment 2 Christoph Hertzberg 2014-11-03 15:52:33 UTC
Ok, sorry for the hasty closing. I guess you intended to actually call
  derived()->resize(...) from DenseBase::resize(...)?
I'm not entirely against that, but we need to carefully avoid recursion where if Derived does not implement resize.
Comment 3 Gael Guennebaud 2014-11-04 00:56:42 UTC
I guess that the idea is rather to move the other variants of resize, i.e., the ones taking NoChange, conservativeResize, etc.
Comment 4 Nobody 2019-12-04 10:21:52 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/196.