Summary: | Requiring C++14 for setting EIGEN_HAS_CONSTEXPR is too strict | ||
---|---|---|---|
Product: | Eigen | Reporter: | Rasmus Munk Larsen <rmlarsen> |
Component: | Core - expression templates | Assignee: | Nobody <eigen.nobody> |
Status: | NEW --- | ||
Severity: | Compilation Problem | CC: | benoit.steiner.goog, chtz, gael.guennebaud, jacob.benoit.1, rmlarsen |
Priority: | Normal | ||
Version: | 3.4 (development) | ||
Hardware: | All | ||
OS: | All | ||
Whiteboard: |
Description
Rasmus Munk Larsen
2018-08-06 23:25:24 UTC
I meant to say that it "disables the IndexLists mechanism", i.e. https://bitbucket.org/eigen/eigen/src/e2ea08bbbe573237b3d196e07ad307eef26aaf7a/unsupported/Eigen/CXX11/src/Tensor/TensorIndexList.h#lines-14 Friendly ping. Can we revert this particular part of the change? hm, I don't see how this commit change anything regarding EIGEN_HAS_CONSTEXPR. AFAIK we always required c++14 to enable EIGEN_HAS_CONSTEXPR. I added Benoit Steiner in CC as I think its him who first introduced EIGEN_HAS_CONSTEXPR. Maybe we should define two variants to handle cases for which relaxed constexpr is not required? EIGEN_HAS_CXX11_CONSTEXPR EIGEN_HAS_CXX14_CONSTEXPR Yes, having two levels of support would be my preference too. -- GitLab Migration Automatic Message -- This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/1583. |