Summary: | Compiling Eigen/Sparse with EIGEN_MPL2_ONLY includes SparseCholesky:#error | ||||||
---|---|---|---|---|---|---|---|
Product: | Eigen | Reporter: | totto <injx032> | ||||
Component: | Sparse | Assignee: | Nobody <eigen.nobody> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Compilation Problem | CC: | chtz, gael.guennebaud | ||||
Priority: | Normal | ||||||
Version: | 3.3 (current stable) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Whiteboard: | |||||||
Attachments: |
|
Thank you for the fix. Applied: https://bitbucket.org/eigen/eigen/commits/4ce22c540fc5/ (default) https://bitbucket.org/eigen/eigen/commits/332d580117b7/ (3.3) -- GitLab Migration Automatic Message -- This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/1392. |
Created attachment 774 [details] Eigen-3.3.2-SparseCholesky-MPL2_ONLY.patch When including Eigen/Sparse and compiling with EIGEN_MPL2_ONLY an #error directive is triggered: Eigen/SparseCholesky:34:2: error: The SparseCholesky module has nothing to offer in MPL2 only mode #error The SparseCholesky module has nothing to offer in MPL2 only mode This can be fixed by checking for the MPL2 define in Eigen/Sparse and skipping Eigen/SparseCholesky if it is set, see attached patch.