This bugzilla service is closed. All entries have been migrated to https://gitlab.com/libeigen/eigen

Bug 1134

Summary:	Condition always false in JacobiSVD::allocate()
Product:	Eigen	Reporter:	Thorsten Harter <thorsten.harter>
Component:	SVD	Assignee:	Nobody <eigen.nobody>
Status:	RESOLVED FIXED
Severity:	Unknown	CC:	chtz, gael.guennebaud, thorsten.harter
Priority:	Normal
Version:	3.2
Hardware:	All
OS:	All
Whiteboard:

Description Thorsten Harter 2015-12-11 09:53:54 UTC

Version: 3.2.7 (2015-11-05)

File: SVD\JacobiSVD.h
Line: 819

if(m_cols!=m_cols)  m_scaledMatrix.resize(rows,cols);

This condition is always false, I assume that it should be if(m_rows!=m_cols) as in line 844.

This didn't cause any troubles, it was only found by the static code analysis tool.

Comment 1 Gael Guennebaud 2015-12-11 11:00:37 UTC

Right!

3.2: https://bitbucket.org/eigen/eigen/commits/4f8c1d263017/
devel: https://bitbucket.org/eigen/eigen/commits/1fcc3a5e161a/

Comment 2 Nobody 2019-12-04 15:16:35 UTC

-- GitLab Migration Automatic Message --

This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/1134.