Summary: | CMAKE_INSTALL_PREFIX used incorrectly | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Eigen | Reporter: | Taylor Braun-Jones <taylor> | ||||||
Component: | General | Assignee: | Nobody <eigen.nobody> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Compilation Problem | CC: | chtz, gael.guennebaud, hmbright, jacob.benoit.1, ludo, manisandro | ||||||
Priority: | Normal | ||||||||
Version: | 3.2 | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Whiteboard: | |||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 558, 711 | ||||||||
Attachments: |
|
Description
Taylor Braun-Jones
2015-10-29 21:47:11 UTC
Thank you for the hint, fixed in devel and 3.2 branches: https://bitbucket.org/eigen/eigen/commits/d26ebad https://bitbucket.org/eigen/eigen/commits/1f02e55 This unfortunately breaks the eigen3.pc file, which now has Cflags: -Iinclude/eigen3 instead of Cflags: -I/usr/include/eigen3 Created attachment 622 [details]
Fix CMAKE_INSTALL_PREFIX missing from generated eigen3.pc
The attached patch follows the convention described at the bottom of this page: https://autotools.io/pkgconfig/file-format.html That patch won't work because ${prefix} will be replaced by an empty string when cmake configures the file, since it thinks that its a variable which it should replace. Created attachment 623 [details]
Fix CMAKE_INSTALL_PREFIX missing from generated eigen3.pc
Whoops, you're right. This updated patch fixes that -- and has actually be tested this time :-)
Thanks Actually, the eigen3.pc wasn't the only thing that broke. Here's a more complete patch to fix the CMAKE_INSTALL_PREFIX correctness in Eigen: https://bitbucket.org/eigen/eigen/pull-requests/143/ Updated pull request: https://bitbucket.org/eigen/eigen/pull-requests/144/ *** Bug 1114 has been marked as a duplicate of this bug. *** Thank you for the updated PR. devel: https://bitbucket.org/eigen/eigen/commits/1db6cf71f628/ 3.2: https://bitbucket.org/eigen/eigen/commits/35a341924dae/ *** Bug 1072 has been marked as a duplicate of this bug. *** -- GitLab Migration Automatic Message -- This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/1100. |