Attachment 833 Details for Bug 1516 – Added eigen_assert() to MatrixBase::diagonal(Index)

This bugzilla service is closed. All entries have been migrated to https://gitlab.com/libeigen/eigen

[patch] Added eigen_assert() to MatrixBase::diagonal(Index)

bug1516 (text/plain), 1.15 KB, created by Mayank Agarwal on 2018-03-12 20:27:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mayank Agarwal

Created: 2018-03-12 20:27:08 UTC

Size: 1.15 KB

patch

obsolete

># HG changeset patch
># User Mayank Agarwal <mayank007.win@gmail.com>
># Date 1520885089 -19800
>#      Tue Mar 13 01:34:49 2018 +0530
># Node ID 6a56e95c4ddb61a15cfdf9f4106ff1fa8b91f432
># Parent  306356e228ecbc70ddc0bcd5880bfa9acb9a16e7
>Added eigen_assert() to MatrixBase::diagonal(Index)
>
>diff --git a/Eigen/src/Core/Diagonal.h b/Eigen/src/Core/Diagonal.h
>--- a/Eigen/src/Core/Diagonal.h
>+++ b/Eigen/src/Core/Diagonal.h
>@@ -208,16 +208,17 @@ MatrixBase<Derived>::diagonal() const
>   * Example: \include MatrixBase_diagonal_int.cpp
>   * Output: \verbinclude MatrixBase_diagonal_int.out
>   *
>   * \sa MatrixBase::diagonal(), class Diagonal */
> template<typename Derived>
> EIGEN_DEVICE_FUNC inline typename MatrixBase<Derived>::DiagonalDynamicIndexReturnType
> MatrixBase<Derived>::diagonal(Index index)
> {
>+  eigen_assert(index < MaxColsAtCompileTime && (-index) < MaxRowsAtCompileTime);
>   return DiagonalDynamicIndexReturnType(derived(), index);
> }
> 
> /** This is the const version of diagonal(Index). */
> template<typename Derived>
> EIGEN_DEVICE_FUNC inline typename MatrixBase<Derived>::ConstDiagonalDynamicIndexReturnType
> MatrixBase<Derived>::diagonal(Index index) const
> {

Actions: View | Diff

Attachments on bug 1516: 833 | 837