Attachment 745 Details for Bug 1325 – Workaround clang 3.5 issue

This bugzilla service is closed. All entries have been migrated to https://gitlab.com/libeigen/eigen

[patch] Workaround clang 3.5 issue

clang_neon.diff (text/plain), 1.12 KB, created by Gael Guennebaud on 2016-10-12 11:44:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Gael Guennebaud

Created: 2016-10-12 11:44:18 UTC

Size: 1.12 KB

patch

obsolete

>diff --git a/Eigen/src/Core/arch/NEON/Complex.h b/Eigen/src/Core/arch/NEON/Complex.h
>--- a/Eigen/src/Core/arch/NEON/Complex.h
>+++ b/Eigen/src/Core/arch/NEON/Complex.h
>@@ -277,18 +277,23 @@ ptranspose(PacketBlock<Packet2cf,2>& ker
>   Packet4f tmp = vcombine_f32(vget_high_f32(kernel.packet[0].v), vget_high_f32(kernel.packet[1].v));
>   kernel.packet[0].v = vcombine_f32(vget_low_f32(kernel.packet[0].v), vget_low_f32(kernel.packet[1].v));
>   kernel.packet[1].v = tmp;
> }
> 
> //---------- double ----------
> #if EIGEN_ARCH_ARM64 && !EIGEN_APPLE_DOUBLE_NEON_BUG
> 
>-const uint64_t  p2ul_conj_XOR_DATA[] = { 0x0, 0x8000000000000000 };
>-static uint64x2_t p2ul_CONJ_XOR = vld1q_u64( p2ul_conj_XOR_DATA );
>+// See bug 1325, clang 3.5 fails to call vld1q_u64.
>+#if EIGEN_COMP_CLANG
>+  static uint64x2_t p2ul_CONJ_XOR = {0x0, 0x8000000000000000};
>+#else
>+  const uint64_t  p2ul_conj_XOR_DATA[] = { 0x0, 0x8000000000000000 };
>+  static uint64x2_t p2ul_CONJ_XOR = vld1q_u64( p2ul_conj_XOR_DATA );
>+#endif
> 
> struct Packet1cd
> {
>   EIGEN_STRONG_INLINE Packet1cd() {}
>   EIGEN_STRONG_INLINE explicit Packet1cd(const Packet2d& a) : v(a) {}
>   Packet2d v;
> };
>

Actions: View | Diff

Attachments on bug 1325: 745 | 746