This bugzilla service is closed. All entries have been migrated to https://gitlab.com/libeigen/eigen
View | Details | Raw Unified | Return to bug 50 | Differences between
and this patch

Collapse All | Expand All

(-)a/Eigen/src/Householder/HouseholderSequence.h (-7 / +8 lines)
Lines 263-274 Link Here
263
263
264
    template<typename _VectorsType, typename _CoeffsType, int _Side> friend struct internal::hseq_side_dependent_impl;
264
    template<typename _VectorsType, typename _CoeffsType, int _Side> friend struct internal::hseq_side_dependent_impl;
265
265
266
    HouseholderSequence& setTrans(bool trans)
267
    {
268
      m_trans = trans;
269
      return *this;
270
    }
271
272
    HouseholderSequence& setLength(Index length)
266
    HouseholderSequence& setLength(Index length)
273
    {
267
    {
274
      m_length = length;
268
      m_length = length;
Lines 281-291 Link Here
281
      return *this;
275
      return *this;
282
    }
276
    }
283
277
284
    bool trans() const { return m_trans; }
285
    Index length() const { return m_length; }
278
    Index length() const { return m_length; }
286
    Index shift() const { return m_shift; }
279
    Index shift() const { return m_shift; }
287
280
288
  protected:
281
  protected:
282
    HouseholderSequence& setTrans(bool trans)
283
    {
284
      m_trans = trans;
285
      return *this;
286
    }
287
288
    bool trans() const { return m_trans; }
289
289
    typename VectorsType::Nested m_vectors;
290
    typename VectorsType::Nested m_vectors;
290
    typename CoeffsType::Nested m_coeffs;
291
    typename CoeffsType::Nested m_coeffs;
291
    bool m_trans;
292
    bool m_trans;
(-)a/Eigen/src/QR/ColPivHouseholderQR.h (-1 / +1 lines)
Lines 484-491 Link Here
484
484
485
    // Note that the matrix Q = H_0^* H_1^*... so its inverse is Q^* = (H_0 H_1 ...)^T
485
    // Note that the matrix Q = H_0^* H_1^*... so its inverse is Q^* = (H_0 H_1 ...)^T
486
    c.applyOnTheLeft(householderSequence(dec().matrixQR(), dec().hCoeffs())
486
    c.applyOnTheLeft(householderSequence(dec().matrixQR(), dec().hCoeffs())
487
                     .setTrans(true)
488
                     .setLength(dec().nonzeroPivots())
487
                     .setLength(dec().nonzeroPivots())
488
		     .transpose()
489
      );
489
      );
490
490
491
    dec().matrixQR()
491
    dec().matrixQR()

Return to bug 50