Attachment 388 Details for Bug 359 – Fix AlignedBit flag of coeff based products

This bugzilla service is closed. All entries have been migrated to https://gitlab.com/libeigen/eigen

[patch] Fix AlignedBit flag of coeff based products

fix_CoeffBasedProduct_AlignedBit.diff (text/plain), 1.29 KB, created by Gael Guennebaud on 2013-10-28 11:43:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Gael Guennebaud

Created: 2013-10-28 11:43:18 UTC

Size: 1.29 KB

patch

obsolete

>diff --git a/Eigen/src/Core/products/CoeffBasedProduct.h b/Eigen/src/Core/products/CoeffBasedProduct.h
>--- a/Eigen/src/Core/products/CoeffBasedProduct.h
>+++ b/Eigen/src/Core/products/CoeffBasedProduct.h
>@@ -80,17 +80,18 @@ struct traits<CoeffBasedProduct<LhsNeste
> 
>       EvalToRowMajor = (MaxRowsAtCompileTime==1&&MaxColsAtCompileTime!=1) ? 1
>                      : (MaxColsAtCompileTime==1&&MaxRowsAtCompileTime!=1) ? 0
>                      : (RhsRowMajor && !CanVectorizeLhs),
> 
>       Flags = ((unsigned int)(LhsFlags | RhsFlags) & HereditaryBits & ~RowMajorBit)
>             | (EvalToRowMajor ? RowMajorBit : 0)
>             | NestingFlags
>-            | (LhsFlags & RhsFlags & AlignedBit)
>+            | (CanVectorizeLhs ? (LhsFlags & AlignedBit) : 0)
>+            | (CanVectorizeRhs ? (RhsFlags & AlignedBit) : 0)
>             // TODO enable vectorization for mixed types
>             | (SameType && (CanVectorizeLhs || CanVectorizeRhs) ? PacketAccessBit : 0),
> 
>       CoeffReadCost = InnerSize == Dynamic ? Dynamic
>                     : InnerSize * (NumTraits<Scalar>::MulCost + LhsCoeffReadCost + RhsCoeffReadCost)
>                       + (InnerSize - 1) * NumTraits<Scalar>::AddCost,
> 
>       /* CanVectorizeInner deserves special explanation. It does not affect the product flags. It is not used outside

Actions: View | Diff

Attachments on bug 359: 387 | 388