Attachment 101 Details for Bug 89 – no boolean redux unrolling with gcc 4.3 : makes array tests pass

This bugzilla service is closed. All entries have been migrated to https://gitlab.com/libeigen/eigen

[patch] no boolean redux unrolling with gcc 4.3 : makes array tests pass

no-booleanredux-unrolling-with-gcc43 (text/plain), 1.68 KB, created by Benoit Jacob on 2011-02-14 03:12:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Benoit Jacob

Created: 2011-02-14 03:12:08 UTC

Size: 1.68 KB

patch

obsolete

># HG changeset patch
># Parent 0112cc942ba817bcb254071e24aab3505b6cdf46
>diff --git a/Eigen/src/Core/BooleanRedux.h b/Eigen/src/Core/BooleanRedux.h
>--- a/Eigen/src/Core/BooleanRedux.h
>+++ b/Eigen/src/Core/BooleanRedux.h
>@@ -87,20 +87,24 @@ struct any_unroller<Derived, Dynamic>
>   * Output: \verbinclude MatrixBase_all.out
>   *
>   * \sa any(), Cwise::operator<()
>   */
> template<typename Derived>
> inline bool DenseBase<Derived>::all() const
> {
>   enum {
>+#if __GNUC__==4 && __GNUC_MINOR__==3
>+    unroll = 0
>+#else
>     unroll = SizeAtCompileTime != Dynamic
>           && CoeffReadCost != Dynamic
>           && NumTraits<Scalar>::AddCost != Dynamic
>           && SizeAtCompileTime * (CoeffReadCost + NumTraits<Scalar>::AddCost) <= EIGEN_UNROLLING_LIMIT
>+#endif
>   };
>   if(unroll)
>     return internal::all_unroller<Derived,
>                            unroll ? int(SizeAtCompileTime) : Dynamic
>      >::run(derived());
>   else
>   {
>     for(Index j = 0; j < cols(); ++j)
>@@ -113,20 +117,24 @@ inline bool DenseBase<Derived>::all() co
> /** \returns true if at least one coefficient is true
>   *
>   * \sa all()
>   */
> template<typename Derived>
> inline bool DenseBase<Derived>::any() const
> {
>   enum {
>+#if __GNUC__==4 && __GNUC_MINOR__==3
>+    unroll = 0
>+#else
>     unroll = SizeAtCompileTime != Dynamic
>           && CoeffReadCost != Dynamic
>           && NumTraits<Scalar>::AddCost != Dynamic
>           && SizeAtCompileTime * (CoeffReadCost + NumTraits<Scalar>::AddCost) <= EIGEN_UNROLLING_LIMIT
>+#endif
>   };
>   if(unroll)
>     return internal::any_unroller<Derived,
>                            unroll ? int(SizeAtCompileTime) : Dynamic
>            >::run(derived());
>   else
>   {
>     for(Index j = 0; j < cols(); ++j)

Actions: View | Diff

Attachments on bug 89: 17 | 18 | 19 | 96 | 98 | 100 | 101 | 102 | 103 | 104