Bug 635 - Adding an isCompressed() property to MappedSparseMatrix
Adding an isCompressed() property to MappedSparseMatrix
Status: RESOLVED FIXED
Product: Eigen
Classification: Unclassified
Component: Sparse
3.2
All All
: Normal Unknown
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-07-24 20:36 UTC by adam.p.harrison
Modified: 2013-08-02 11:12 UTC (History)
1 user (show)



Attachments
Patch that implements what's proposed in the bug report (52 bytes, patch)
2013-07-24 20:39 UTC, adam.p.harrison
adam.p.harrison: review? (gael.guennebaud)
Details | Diff

Description adam.p.harrison 2013-07-24 20:36:17 UTC
The new SparseLU module checks whether the matrix in question is already in compressed mode. Unfortunately, when decomposing a MappedSparseMatrix, a compile error will occur as the MappedSparseMatrix does not have a isCompressed() function.

If I'm not mistaken, the MappedSparseMatrix is always wrapping compressed data, so it should be correct to add a isCompressed() function that always return true.
Comment 1 adam.p.harrison 2013-07-24 20:39:59 UTC
Created attachment 372 [details]
Patch that implements what's proposed in the bug report

I just added an isCompressed() member function in MappedSparseMatrix that always returns true. I believe that is consistent with the design and intentions of MappedSparseMatrix.
Comment 2 Gael Guennebaud 2013-08-02 11:12:31 UTC
Thank you.

https://bitbucket.org/eigen/eigen/commits/773a8bf23df6/
Changeset:   773a8bf23df6
User:        ggael
Date:        2013-08-02 11:11:21
Summary:     Fix bug 635: add isCompressed to MappedSparseMatrix for compatibility
Affected #:  1 file

https://bitbucket.org/eigen/eigen/commits/9343ccc56542/
Changeset:   9343ccc56542
Branch:      3.2
User:        ggael
Date:        2013-08-02 11:11:21
Summary:     Fix bug 635: add isCompressed to MappedSparseMatrix for compatibility
(transplanted from 773a8bf23df6a7ca7dd0b17e3bb90446c683d7e9)

Note You need to log in before you can comment on or make changes to this bug.