Bug 417 - Map should be nested by value, right?
: Map should be nested by value, right?
Status: RESOLVED FIXED
Product: Eigen
Classification: Unclassified
Component: Core - general
: 3.0
: All All
: Normal major
Assigned To: Nobody
:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-02-09 13:47 UTC by Gael Guennebaud
Modified: 2012-02-09 15:27 UTC (History)
2 users (show)



Attachments
patch to nest Map by value (2.40 KB, application/octet-stream)
2012-02-09 13:47 UTC, Gael Guennebaud
no flags Details

Description Gael Guennebaud 2012-02-09 13:47:06 UTC
Created attachment 251 [details]
patch to nest Map by value

Currently Map objects are nested by reference while it seems to me that they
should be nested by value just like Block<> are currently nested by value.

The attached patch fix that. Please tell me if I'm overseeing something.

On a side note, using HereditaryBits instead of ~NestedByRefBit for the mask
generates many compilation errors... That's why I currently propose to only
remove that bit for now.
Comment 1 Gael Guennebaud 2012-02-09 15:27:33 UTC
https://bitbucket.org/eigen/eigen/changeset/8242ba5bc94e/
changeset:   8242ba5bc94e
user:        ggael
date:        2012-02-09 15:25:42
summary:     fix bug 417: Map should be nested by value, not by reference

https://bitbucket.org/eigen/eigen/changeset/14791ccf153b/
changeset:   14791ccf153b
branch:      3.0
user:        ggael
date:        2012-02-09 15:25:42
summary:     fix bug 417: Map should be nested by value, not by reference

Note You need to log in before you can comment on or make changes to this bug.