This bugzilla service is closed. All entries have been migrated to https://gitlab.com/libeigen/eigen
Bug 379 - FullPivLU should not stops the decomposition
Summary: FullPivLU should not stops the decomposition
Status: RESOLVED FIXED
Alias: None
Product: Eigen
Classification: Unclassified
Component: LU (show other bugs)
Version: 3.0
Hardware: All All
: Normal major
Assignee: Nobody
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-21 19:35 UTC by Gael Guennebaud
Modified: 2019-12-04 11:16 UTC (History)
1 user (show)



Attachments

Description Gael Guennebaud 2011-11-21 19:35:07 UTC
I think that FullPivLU should stop the decomposition if and only if it encounters an exact 0, just like PartialPivLU does. Thresholding should only happen when computing the rank and the like.

See for instance this thread: http://forum.kde.org/viewtopic.php?f=74&t=97884
Comment 1 Benoit Jacob 2011-11-21 19:45:48 UTC
Sounds like a good idea. I didn't know/remember that FullPivLU behaved like that. Indeed, the threshold stuff should only affect rank() and the like.
Comment 2 Gael Guennebaud 2011-11-22 10:22:01 UTC
fixed by: e5fa60b5e3d7, 06fa6099f5b5
Comment 3 Nobody 2019-12-04 11:16:30 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to gitlab.com's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.com/libeigen/eigen/issues/379.

Note You need to log in before you can comment on or make changes to this bug.