New user self-registration is disabled due to spam. Please email eigen-core-team @ lists.tuxfamily.org if you need an account.
Before reporting a bug, please make sure that your Eigen version is up-to-date!
Bug 323 - name of constant
Summary: name of constant
Status: DECISIONNEEDED
Alias: None
Product: Eigen
Classification: Unclassified
Component: Core - general (show other bugs)
Version: unspecified
Hardware: All All
: Lowest API Change
Assignee: Nobody
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 4.0
  Show dependency treegraph
 
Reported: 2011-08-07 23:05 UTC by Benito van der Zander
Modified: 2015-04-29 13:03 UTC (History)
3 users (show)



Attachments

Description Benito van der Zander 2011-08-07 23:05:11 UTC
In Constants.h there is a definition "const int Infinity = -1;"

This is a very bad name, because it is easily confused with an constant for an actual infinity (i.e. INFINITY); and doesn't reflect the fact that it means the infinity norm.

You should use something like InfinityNorm.

(This becomes especially annoying if you use Qt Creator which autocompletes "INF" to "Infinity")
Comment 1 Gael Guennebaud 2011-08-23 09:22:50 UTC
We cannot change that name since that would break the API. Perhaps this could be considered for Eigen 4 in a very far future...
Comment 2 Benoit Jacob 2011-08-23 23:44:06 UTC
We can however introduce a new constant with the same value; and possibly mark the existing one as deprecated.

Note You need to log in before you can comment on or make changes to this bug.