Bug 207 - possible indexing error in ei_transform_right_product_impl
: possible indexing error in ei_transform_right_product_impl
Status: RESOLVED FIXED
Product: Eigen
Classification: Unclassified
Component: Geometry
: 3.0
: All All
: --- normal
Assigned To: Nobody
:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-03-01 19:57 UTC by Evan Herbst
Modified: 2011-09-07 15:14 UTC (History)
3 users (show)



Attachments
patch to Transform.h (413 bytes, patch)
2011-03-01 19:57 UTC, Evan Herbst
no flags Details | Diff | Splinter Review
a fix for transform * MatrixBase product (3.96 KB, patch)
2011-03-02 15:08 UTC, Gael Guennebaud
no flags Details | Diff | Splinter Review

Description Evan Herbst 2011-03-01 19:57:43 UTC
Created attachment 111 [details] [review]
patch to Transform.h

It uses rows() as an index. There's a comment I don't understand just above the
line in question so I'm not quite sure what's going on, but with no -1 I get
runtime errors.
Comment 1 Gael Guennebaud 2011-03-02 15:08:04 UTC
Created attachment 112 [details] [review]
a fix for transform * MatrixBase product

it seems to me that this product suffered from more serious issues, like
neglecting the homogeneous component of the right hand side. Here is what I
think is a more correct patch but it needs confirmation because I might have
overseen something.
Comment 2 Benoit Jacob 2011-03-02 15:22:22 UTC
I don't really have time to do this review now, as I'm not myself very familiar
with this part of the code. Could you just add tests?
Comment 3 Gael Guennebaud 2011-03-04 15:58:25 UTC
fixed by rev 31cc13f677d3

Note You need to log in before you can comment on or make changes to this bug.