New user self-registration is currently disabled. Please email eigen-core-team @ lists.tuxfamily.org if you need an account.
Bug 1164 - Compilation error EIGEN_DEFINE_STL_LIST_SPECIALIZATION and IGEN_DEFINE_STL_DEQUE_SPECIALIZATION
Compilation error EIGEN_DEFINE_STL_LIST_SPECIALIZATION and IGEN_DEFINE_STL_DE...
Status: RESOLVED FIXED
Product: Eigen
Classification: Unclassified
Component: Core - general
unspecified
All All
: Normal Unknown
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2016-02-03 10:39 UTC by Damien R
Modified: 2016-02-03 17:14 UTC (History)
3 users (show)



Attachments
patch (15.02 KB, patch)
2016-02-03 10:39 UTC, Damien R
no flags Details | Diff
patch (15.02 KB, patch)
2016-02-03 10:54 UTC, Damien R
no flags Details | Diff

Description Damien R 2016-02-03 10:39:36 UTC
Created attachment 651 [details]
patch

This is the same problem as #282 but for list and deque specialization.
The patch is based r4201 and r4203 and the tests are based on stdvector_overload but without the test of continuous of data.
I kept the following part of the test but I do not understand it.
// do a lot of push_back such that the vector gets internally resized
// (with memory reallocation)
MatrixType* ref = &w[0];
for(int i=0; i<30 || ((ref==&w[0]) && i<300); ++i)
...
I think that I should be ref = &v[0] and ref==&v[0].
Comment 1 Damien R 2016-02-03 10:54:01 UTC
Created attachment 652 [details]
patch
Comment 2 Gael Guennebaud 2016-02-03 17:14:35 UTC
Great, thanks for the patch:

devel: https://bitbucket.org/eigen/eigen/commits/99134de9db78/
3.2:   https://bitbucket.org/eigen/eigen/commits/e3e1645c150a/

Note You need to log in before you can comment on or make changes to this bug.