New user self-registration is currently disabled. Please email eigen-core-team @ lists.tuxfamily.org if you need an account.
Bug 1010 - IncompleteLUT - Initialization flag m_isInitialized incorrectly set
IncompleteLUT - Initialization flag m_isInitialized incorrectly set
Status: RESOLVED FIXED
Product: Eigen
Classification: Unclassified
Component: Sparse
3.2
All All
: Normal Internal Design
Assigned To: Nobody
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-05-04 14:48 UTC by simon.floery
Modified: 2015-05-07 12:27 UTC (History)
2 users (show)



Attachments

Description simon.floery 2015-05-04 14:48:50 UTC
Hi,

Current preconditioner IncompleteLUT sets the initialization flag m_isInitialized only in IncompleteLUT::compute. This makes the solve method assert if analyzePattern and factorize were called separately, e.g. not via compute. DiagonalPreconditioner sets the m_isInitialized flag in factorize, which should be a feasible solution for IncompleteLUT as well.

best, simon
Comment 1 Gael Guennebaud 2015-05-07 12:27:29 UTC
thank you for the report, fixed:

default: https://bitbucket.org/eigen/eigen/commits/b9b2a5516325/
3.2:     https://bitbucket.org/eigen/eigen/commits/941725bff733/

Note You need to log in before you can comment on or make changes to this bug.